#[cfg(feature = "render")] and yew::Renderer
#2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a3efdb2): https://yew-rs--pr2498-feat-render-lo1tccs5.web.app (expires Sat, 26 Mar 2022 00:32:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
# Conflicts: # examples/function_router/Cargo.toml # examples/function_router/index.html # examples/function_router/src/main.rs # packages/yew/Cargo.toml
# Conflicts: # packages/yew/src/app_handle.rs # packages/yew/src/dom_bundle/bcomp.rs # packages/yew/src/html/component/scope.rs # packages/yew/src/lib.rs # packages/yew/src/virtual_dom/vcomp.rs
futursolo
commented
Mar 9, 2022
|
Just requesting my own review so I don't forget to look at this |
hamza1311
reviewed
Mar 17, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Size Comparison
|
|
The measured drop in size for |
|
function_router has feature render disabled by default because it's also used in ssr by the upcoming ssr_router example. |
|
I suspected as much. Then this is a perfect example of the benefit of having |
voidpumpkin
approved these changes
Mar 19, 2022
|
I will merge this pull request as I believe all items has been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally part of #2453.
yew::Rendererthat supersedesstart_app_*.renderallowing client-side rendering logic to be disabled for server-side rendering.This pull request also includes changes from the following pull requests to avoid repeatedly resolving conflicts:
Caveats
This pull request inevitably introduces a lot of feature flags into the codebase.
However, I don't have a better way to handle this at the moment.
Checklist
cargo make pr-flow