Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl ImplicitClone for Rc<T> when T is not Sized #2594

Merged
merged 1 commit into from Apr 9, 2022

Conversation

nanoqsh
Copy link
Contributor

@nanoqsh nanoqsh commented Apr 9, 2022

Description

Add ?Sized bound in ImplicitClone implementation for Rc<T> to use clone implicitly for types like Rc<str>.

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@WorldSEnder WorldSEnder changed the title Impl ImplicitClone for Rc<T> where T: Sized Impl ImplicitClone for Rc<T> when T is not Sized Apr 9, 2022
Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, good catch, no objections from me.

@WorldSEnder WorldSEnder added this to the v0.20 milestone Apr 9, 2022
@WorldSEnder WorldSEnder added the A-yew Area: The main yew crate label Apr 9, 2022
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

Visit the preview URL for this PR (updated for commit 51725e0):

https://yew-rs-api--pr2594-master-u7zaeenr.web.app

(expires Sat, 16 Apr 2022 03:35:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

Size Comparison

examples master (KB) pull request (KB) diff
boids 316.195 316.195 0
contexts 236.473 236.473 0
counter 170.271 170.271 0
dyn_create_destroy_apps 178.446 178.446 0
file_upload 199.709 199.709 0
function_memory_game 354.096 354.096 0
function_router 406.100 406.100 0
function_todomvc 329.197 329.197 0
futures 367.216 367.216 0
game_of_life 212.076 212.076 0
inner_html 161.433 161.433 0
js_callback 177.299 177.299 0
keyed_list 333.856 333.856 0
mount_point 169.175 169.175 0
nested_list 229.945 229.945 0
node_refs 175.815 175.815 0
password_strength 1853.995 1853.995 0
portals 188.844 188.844 0
router 591.184 591.184 0
simple_ssr 573.165 573.165 0
ssr_router 495.398 495.398 0
suspense 225.844 225.844 0
timer 176.073 176.073 0
todomvc 275.007 275.007 0
two_apps 171.125 171.125 0
webgl 175.735 175.735 0

@siku2 siku2 merged commit ae26885 into yewstack:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants