use_prepared_state & use_transitive_state
#2650
Conversation
# Conflicts: # packages/yew/src/html/component/scope.rs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit f01c200): https://yew-rs-api--pr2650-fc-prepared-state-nb5wk40u.web.app (expires Mon, 30 May 2022 23:44:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
|
futursolo
added
A-examples
|
@hamza1311 Could you please give this pull request a review so the second part in #2649 can proceed forward? |
| } | ||
|
|
||
| impl PreparedState { | ||
| // Async closure is not stable, so we rewrite it to clsoure + async block |
| @@ -29,6 +29,10 @@ thiserror = "1.0" | |||
|
|
|||
| futures = { version = "0.3", optional = true } | |||
| html-escape = { version = "0.2.9", optional = true } | |||
| base64ct = { version = "1.5.0", features = ["std"], optional = true } | |||
| bincode = { version = "1.3.3", optional = true } | |||
There was a problem hiding this comment.
Not blocking but it would be nice if we could change the implementation, similar to how the global allocator can be changed. If one wants to use JSON, BSON, etc for this, they should have the option to do so
There was a problem hiding this comment.
We should create a separate issue for this. Can you create one when merging this PR?
futursolo
dismissed stale reviews from ranile and github-actions[bot]
via
1f0b5e1
| @@ -0,0 +1,55 @@ | |||
| error: expected `|` | |||
There was a problem hiding this comment.
Can we make this "expected closure, found <whatever>"?
| error: expected a second argument as dependency | ||
| --> tests/hook_macro/use_prepared_state-fail.rs:10:5 | ||
| | | ||
| 10 | use_prepared_state_with_closure!(|_| -> u32 { todo!() })?; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Can we keep this similar to rustc's missing argument error:
error: this hook takes 2 arguments but 1 argument were supplied
with the span pointing at the missing argument.
Example from rustc:
error[E0061]: this function takes 2 arguments but 1 argument was supplied
--> src/main.rs:4:5
|
4 | hook("123")
| ^^^^ ----- supplied 1 argument
| |
| expected 2 arguments
There was a problem hiding this comment.
I don't think this is possible with syn::Error as you cannot emit an error in which its span is beyond its input (the hook name itself) unless Span::call_site() is used.
| @@ -29,6 +29,10 @@ thiserror = "1.0" | |||
|
|
|||
| futures = { version = "0.3", optional = true } | |||
| html-escape = { version = "0.2.9", optional = true } | |||
| base64ct = { version = "1.5.0", features = ["std"], optional = true } | |||
| bincode = { version = "1.3.3", optional = true } | |||
There was a problem hiding this comment.
We should create a separate issue for this. Can you create one when merging this PR?
Description
This pull request implements 2 hooks that allows states created during SSR to be carried over to the client side for hydration.
See: #2649
Please refer to the API docs for how to use these hooks:
About the implementation
I have tested the following implementation for data serialisation:
bincode+base64serde_jsonserde_qsThe
bincode+base64option results in the smallest hydration bundle and html artifact size overall when tested with a combination of multiple data types.Checklist