Partially undo #2673, different approach for the DerefMut impl of VList #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VList again has a DerefMut implementation the internal fully_keyed state now has an "indeterminate" variant instead of being a bool, this recomputes it during reconciliation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit 8b2d8de): https://yew-rs-api--pr2692-vlist-take-two-518v5s88.web.app (expires Tue, 31 May 2022 20:51:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
hamza1311
requested changes
May 24, 2022
Comment on lines
6
to
7
| #[derive(Clone, Debug, PartialEq)] | ||
| enum FullyKeyedState { |
There was a problem hiding this comment.
This should have a Copy implementation. Or is there a reason you chose not to add it?
There was a problem hiding this comment.
None in particular, except being a little less careful since it's internal. Will add.
hamza1311
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VList again has a DerefMut implementation, undoes parts of #2673. The internal fully_keyed state now has an "indeterminate" variant instead of being just a bool, during reconciliation this indeterminate state recomputes the bool from the incoming children.
Fixes #2689
Checklist