Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback::reform() should return Callback<T, OUT> #2719

Merged
merged 1 commit into from Jun 5, 2022

Conversation

orzogc
Copy link
Contributor

@orzogc orzogc commented Jun 5, 2022

Description

Callback::reform() should return Callback<T, OUT> instead of Callback<T>.

Checklist

  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Visit the preview URL for this PR (updated for commit f545ffd):

https://yew-rs-api--pr2719-callback-r3r2kv39.web.app

(expires Sun, 12 Jun 2022 13:24:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 172.978 172.978 0 0.000%
contexts 109.753 109.753 0 0.000%
counter 86.719 86.719 0 0.000%
counter_functional 87.371 87.371 0 0.000%
dyn_create_destroy_apps 89.862 89.862 0 0.000%
file_upload 102.795 102.795 0 0.000%
function_memory_game 167.428 167.428 0 0.000%
function_router 350.024 350.024 0 0.000%
function_todomvc 162.074 162.074 0 0.000%
futures 227.084 227.084 0 0.000%
game_of_life 107.706 107.706 0 0.000%
inner_html 83.789 83.789 0 0.000%
js_callback 112.977 112.977 0 0.000%
keyed_list 195.257 195.257 0 0.000%
mount_point 86.349 86.349 0 0.000%
nested_list 116.088 116.088 0 0.000%
node_refs 90.542 90.542 0 0.000%
password_strength 1538.481 1538.481 0 0.000%
portals 97.358 97.358 0 0.000%
router 318.985 318.985 0 0.000%
simple_ssr 153.690 153.690 0 0.000%
ssr_router 395.478 395.478 0 0.000%
suspense 110.663 110.663 0 0.000%
timer 89.457 89.457 0 0.000%
todomvc 143.129 143.129 0 0.000%
two_apps 87.330 87.330 0 0.000%
web_worker_fib 153.772 153.772 0 0.000%
webgl 87.610 87.610 0 0.000%

✅ None of the examples has changed their size significantly.

@WorldSEnder WorldSEnder added breaking change A-yew Area: The main yew crate labels Jun 5, 2022
Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! That must've been oversight on my part when changing the Callback related code

Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Not part of this PR, but did you feel any need for a similar method changing the OUT type of the callback by transforming it through a function?

@WorldSEnder WorldSEnder merged commit 7221933 into yewstack:master Jun 5, 2022
@orzogc orzogc deleted the callback branch June 23, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants