-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert nightly from a feature flag to a compiler flag #2827
Conversation
Visit the preview URL for this PR (updated for commit 0b843f7): https://yew-rs-api--pr2827-nightly-yew-compiler-pt5313ki.web.app (expires Sun, 21 Aug 2022 18:00:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This should make the development process easier.
env: | ||
# workaround for lack of ternary operator | ||
# see https://github.com/orgs/community/discussions/25725 | ||
RUSTFLAGS: ${{ matrix.toolchain == 'nightly && '--cfg nightly_yew' || '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUSTFLAGS: ${{ matrix.toolchain == 'nightly && '--cfg nightly_yew' || '' }} | |
RUSTFLAGS: ${{ matrix.toolchain == 'nightly' && '--cfg nightly_yew' || '' }} |
Oops, didn't find this during the review.
Description
Fixes #2754
Checklist
added testsupdated CI to run tests