Fix Tooltip to Allow Text Wrapping #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
commented
Oct 26, 2023
nmanu1
reviewed
Oct 30, 2023
e2e-tests/__screenshots__/nested-props.spec.ts/renders-nested-props-2.png
Outdated
Show resolved
Hide resolved
nmanu1
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the tooltip to wrap when the text is too long, as opposed to getting cut off by the end of the screen. I've attached some screen shots to show some of the edge cases. This tooltip closes on scroll, and will work as expected in different scrolled positions. Although it has "fixed" positioning, react-tooltip ensures that scroll behavior works as expected. The tooltip has also now been moved to above the tooltip, which was approved by Product.
Here is a loom of some of the behavior in different edge cases.
This PR also addresses a small bug where if the side panel becomes small enough, the undefined menu button and the info icon would overlap. To get around this, right margin was added to the icon. Some left padding from the icon was also removed since the gap was a little awkward.
J=SLAP-2958
TEST=manual