Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCaml 4.12 #55

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Add support for OCaml 4.12 #55

merged 2 commits into from
Nov 15, 2020

Conversation

kit-ty-kate
Copy link
Contributor

OCaml 4.12 added List.compare and now shadows Pervasives.compare in this particular context.

@ygrek ygrek merged commit 574e8ea into ygrek:master Nov 15, 2020
@ygrek
Copy link
Owner

ygrek commented Nov 15, 2020

Thanks!

@kit-ty-kate
Copy link
Contributor Author

Would it be possible to get a release somewhat soon? opam depends on extlib and it'd be very helpful to have a release and not add patches.

@kit-ty-kate
Copy link
Contributor Author

ping @ygrek

@ygrek
Copy link
Owner

ygrek commented Jan 14, 2021

Was waiting for resolution on ocaml/ocaml#10105
Now there is also ocaml/ocaml#10140 which I probably want to test against before release.

@kit-ty-kate
Copy link
Contributor Author

As far as I know ocaml/ocaml#10140 is not coming in OCaml 4.12 but in 4.13

@ygrek
Copy link
Owner

ygrek commented Jan 14, 2021

ah, right. Then I have no excuse :)

@ygrek
Copy link
Owner

ygrek commented Jan 20, 2021

sternenseemann added a commit to sternenseemann/nixpkgs that referenced this pull request Mar 16, 2021
Pull in patches from ygrek/ocaml-extlib#55
which add support for OCaml 4.12. These patches are also included in
extlib 1.7.8, however extlib 1.7.8 includes some API changes which break
for example google-drive-ocamlfuse.

Therefore we follow the opam repository and patch our default extlib
version: ocaml/opam-repository#18041
vbgl pushed a commit to NixOS/nixpkgs that referenced this pull request Mar 16, 2021
Pull in patches from ygrek/ocaml-extlib#55
which add support for OCaml 4.12. These patches are also included in
extlib 1.7.8, however extlib 1.7.8 includes some API changes which break
for example google-drive-ocamlfuse.

Therefore we follow the opam repository and patch our default extlib
version: ocaml/opam-repository#18041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants