-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCaml 4.12 #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! |
This was referenced Nov 18, 2020
Would it be possible to get a release somewhat soon? opam depends on extlib and it'd be very helpful to have a release and not add patches. |
ping @ygrek |
Was waiting for resolution on ocaml/ocaml#10105 |
As far as I know ocaml/ocaml#10140 is not coming in OCaml 4.12 but in 4.13 |
ah, right. Then I have no excuse :) |
10 tasks
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Mar 16, 2021
Pull in patches from ygrek/ocaml-extlib#55 which add support for OCaml 4.12. These patches are also included in extlib 1.7.8, however extlib 1.7.8 includes some API changes which break for example google-drive-ocamlfuse. Therefore we follow the opam repository and patch our default extlib version: ocaml/opam-repository#18041
10 tasks
vbgl
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Mar 16, 2021
Pull in patches from ygrek/ocaml-extlib#55 which add support for OCaml 4.12. These patches are also included in extlib 1.7.8, however extlib 1.7.8 includes some API changes which break for example google-drive-ocamlfuse. Therefore we follow the opam repository and patch our default extlib version: ocaml/opam-repository#18041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml 4.12 added
List.compare
and now shadowsPervasives.compare
in this particular context.