Switched to PS Core with a legacy PS fallback #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanwayb
added a commit
to bryanwayb/envy
that referenced
this pull request
Jan 30, 2023
Will need to switch back once PR is approved, merged, and deployed: yibn2008/find-process#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSCore has a faster load time and offers the same functionality required for find-process over the legacy .NET Framework based versions.
This change is to switched the PowerShell spawning to prioritize PSCore (pwsh.exe) over the legacy PS versions (powershell.exe) by manually performing the binary lookup to pass in to the
utils.spawncommand before executing. If the pwsh.exe executable exists, it will execute that, and if not it will attempt to find a powershell.exe executable instead. If none is found, an error is thrown.Milage may vary, but with my local testing I see on average ~450ms of a speed reduction. (The PSCore version taking aprox ~450ms to run, PS Legacy taking ~900ms).