Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DateTime instances #268

Closed
wants to merge 1 commit into from
Closed

Support DateTime instances #268

wants to merge 1 commit into from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 5, 2023

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #725

@what-the-diff
Copy link

what-the-diff bot commented Aug 5, 2023

PR Summary

  • Updated Date/Time Test in 'ActiveRecordTest.php'
    The changes in this file revolve around enhancing the way we verify date and time information. More specifically, the tests now cross-verify date and time data against "DateTimeImmutable", a more reliable standard in PHP for dealing with time-related data.

  • Improved Date/Time Test in 'Oracle/ActiveRecordTest.php'
    The changes in this file are similar to the previous one, but are specific to our interaction with Oracle databases. The modification provides a more rigorous standard for date and time verification, ensuring our application remains in harmony with Oracle databases, thereby boosting our data integrity.

@Tigrov Tigrov marked this pull request as ready for review August 5, 2023 16:19
@Tigrov Tigrov marked this pull request as draft August 17, 2023 13:51
@Tigrov Tigrov closed this May 24, 2024
@Tigrov Tigrov deleted the support_datetime_instances branch May 24, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terabytesoftw terabytesoftw Awaiting requested review from terabytesoftw

@darkdef darkdef Awaiting requested review from darkdef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Tigrov