Skip chmod if permission is already the same #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean by "sensitive permission"? |
samdark
reviewed
Mar 15, 2021
| @@ -93,6 +93,11 @@ public static function ensureDirectory(string $path, int $mode = 0775): void | |||
| restore_error_handler(); | |||
| } | |||
|
|
|||
| // Skip chmod if permission is already the same | |||
| if (fileperms($path) == $mode) { | |||
There was a problem hiding this comment.
Suggested change
| if (fileperms($path) == $mode) { | |
| if (fileperms($path) === $mode) { |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code if chmod is not permitted, php 7.4 throws a warning and the exception actually won't get thrown.
If we need to ensureDirectory an existing directory (which the developer may not know it existed and with sensitive permission), it will overwrite the original permission which may not be desired.