-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list of mime types #48
base: master
Are you sure you want to change the base?
Conversation
xepozz
commented
Sep 10, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage 99.17% 99.17%
Complexity 46 46
=========================================
Files 2 2
Lines 121 121
=========================================
Hits 120 120
Misses 1 1 ☔ View full report in Codecov by Sentry. |
PR Summary
The benefit of this addition is it allows our system to better identify, handle, and categorize different types of files. This could aid in document management, file transfers, data structure, and increased overall efficiency in our project's operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort them alphabetically?
Are these common mime types only?
There is a list of all the official MIME types.
https://www.iana.org/assignments/media-types/media-types.xhtml
I've pasted as is from MDN, but the suggestion make sense.
There are a lot of not web-related types, so I used another link https://github.com/mdn/content/blob/main/files/en-us/web/http/basics_of_http/mime_types/common_types/index.md where are collected most used web-related mime-types. If someone wants to add more he can open a new PR. |
In MDN they sorted by file extension. In the class better sort the constants alphabetically. |