Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of mime types #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add list of mime types #48

wants to merge 3 commits into from

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Sep 10, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (662b3c7) 99.17% compared to head (67ca56e) 99.17%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage     99.17%   99.17%           
  Complexity       46       46           
=========================================
  Files             2        2           
  Lines           121      121           
=========================================
  Hits            120      120           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@what-the-diff
Copy link

what-the-diff bot commented Sep 10, 2023

PR Summary

  • Addition of Mime Class
    This update introduces a new file named Mime.php into the source code. This particular document contains a defined class called Mime which provides a set of constants representing various file type categories, called MIME types. Each of these categories is defined by a detailed description, a hyperlink for further information, and the associated file extension.

The benefit of this addition is it allows our system to better identify, handle, and categorize different types of files. This could aid in document management, file transfers, data structure, and increased overall efficiency in our project's operations.

Copy link
Member

@Tigrov Tigrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort them alphabetically?

Are these common mime types only?

There is a list of all the official MIME types.
https://www.iana.org/assignments/media-types/media-types.xhtml

@xepozz
Copy link
Contributor Author

xepozz commented Sep 11, 2023

Sort them alphabetically?

I've pasted as is from MDN, but the suggestion make sense.

Are these common mime types only?
There is a list of all the official MIME types. https://www.iana.org/assignments/media-types/media-types.xhtml

There are a lot of not web-related types, so I used another link https://github.com/mdn/content/blob/main/files/en-us/web/http/basics_of_http/mime_types/common_types/index.md where are collected most used web-related mime-types. If someone wants to add more he can open a new PR.

@Tigrov
Copy link
Member

Tigrov commented Sep 11, 2023

I've pasted as is from MDN, but the suggestion make sense.

In MDN they sorted by file extension. In the class better sort the constants alphabetically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants