Make $end parameter nullable in findBetween Method

[salehhashemi1992]

Implemented logic to default the $end parameter to the $start value when $end is null.

[what-the-diff]

PR Summary

• Modification of 'findBetween' method in 'BaseStringHelper.php' file
  • The procedure for identifying characters between specific points in a string has been enhanced. This method now optionally accepts a parameter indicating where to stop ('end').
  • If this 'end' parameter isn't specified, the method will default to using the starting point ('start') as the endpoint.
  • The method is also more robust now: even if the 'end' parameter is unknowingly supplied as 'null', it will be reset to match the starting point.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01f3983) 48.02% compared to head (88101c4) 48.02%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20062      +/-   ##
==========================================
- Coverage   48.02%   48.02%   -0.01%     
==========================================
  Files         445      445              
  Lines       43890    43892       +2     
==========================================
- Hits        21078    21077       -1     
- Misses      22812    22815       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rob006]

I'm not sure about this feature overall, but I definitely don't like current signature. Making $end nullable only make sense if passing $end is optional. Explicitly passing null as third argument only makes call more cryptic.

[salehhashemi1992]

I'm not sure about this feature overall, but I definitely don't like current signature. Making $end nullable only make sense if passing $end is optional. Explicitly passing null as third argument only makes call more cryptic.

I apologize; that was my mistake.
This feature is suggested here: yiisoft/strings#118 (comment)