Function chaining of shared types #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, any updates on this @dmonad? Regards, |
|
Hey @Mansehej , sorry for coming back to you so late. So I thought about making another stable release soon but decided that I want to wait a few more months before shipping a release with breaking changes. This is pretty unfortunate because I really like this feature .. Anyway, thank you so much for working on this! I'll make sure that this feature is merged before the next major release.
|
dmonad
added
the
next-release
|
Just as a quick question @dmonad, how much longer do you plan to wait before the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @dmonad
I've implemented function chaining in all the shared types.
I had to change the tests of y-map as they were written considering that ymap.set(key,value) returns the value itself.
Please review this PR and let me know what you think.
Regards,
Mansehej.