Improve types for Y.Map's public interface #614
Conversation
…-public-interface
Smona
changed the title
| @@ -74,7 +99,7 @@ export class YMap extends AbstractType { | |||
| */ | |||
| _integrate (y, item) { | |||
| super._integrate(y, item) | |||
| ;/** @type {Map<string, any>} */ (this._prelimContent).forEach((value, key) => { | |||
| this._prelimContent?.forEach((value, key) => { | |||
There was a problem hiding this comment.
note this logic change, but if _prelimContent was null previously then this would have created a runtime error.
|
Thanks for the PR! This is on the roadmap for v14, as it is a breaking change. However, this feature is not "enough" for a new v14 release. I don't want to create too many releases for Yjs. I'll keep this PR around for now. Note: I dislike the |
|
Feel free to point me towards the v14 roadmap (couldn't find it with a cursory search) -- I'd be happy to assist with any other (potentially breaking) type improvements you would like to include. These are just the main type issues I'm aware of. In the meantime, I'll try to get the TS file migrated to JS and included in |
Huly®: YJS-427