Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink Resource Artifacts #265

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jagreenwood
Copy link

The PR seeks to address the issue outlined in #261. The issue being that resource artifacts such as bundles are not found, causing termination.

I've implemented a naive solution which is to create symlinks for resource artifacts when a package is installed, as noted as a workaround in SwiftGen/SwiftGen#905. I'm also deleting the symlinks when packages are uninstalled.

I acknowledge there could be concern about namespace collisions, however I see this as an extreme edge case and the same collisions would exist with the executable target, unless I'm missing something.

Please let me know if any improvements could be made to help get this merged.

@yaroslavyaroslav
Copy link

@yonaskolb any update about this being merged?

@jagreenwood
Copy link
Author

btw I found an issue with the implementation where the symlink is not updated when a package is upgraded.
I'll get a fix for that soon.

@yaroslavyaroslav
Copy link

@jagreenwood that would awesome, at least some of us could use it as one used Carthage util while it were broken on the main repo for an about a year.

@jagreenwood
Copy link
Author

jagreenwood commented Oct 5, 2023

@yaroslavyaroslav ok the upgrade bug should be fixed.

Also since this hasn't been merged, I've been using the changes on this branch with.

mint install jagreenwood/Mint@bugfix/artifact-symlink

Give it a try in the meantime if you'd like.

@yaroslavyaroslav
Copy link

@jagreenwood Thanks a lot! It works well on my side, just required to do some uninstall/install hassle with corrupted packages and mint itself to make it work with your branch, but after that — everything gone smoothly.

@alexfanatics
Copy link

Is there a plan to merge this? We're seeing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants