Reset online clients when stream is disconnected #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7hong13
commented
May 16, 2024
| @@ -18,9 +18,9 @@ public class Presences private constructor( | |||
|
|
|||
| public operator fun minus(actorID: ActorID): Presences = (map - actorID).asPresences() | |||
|
|
|||
| override fun hashCode(): Int = map.hashCode() | |||
|
|
|||
| override fun equals(other: Any?): Boolean = map == (other as? Presences)?.map | |||
There was a problem hiding this comment.
I removed it to ensure that document.publishPresenceEvent() is properly invoked whenever a new value is emitted to document.presences.
skhugh
reviewed
May 16, 2024
| } | ||
| val streamJob = launch(start = CoroutineStart.UNDISPATCHED) { | ||
| val channel = stream.responseChannel() | ||
| var retry = 0 | ||
| while (!stream.isReceiveClosed() && !channel.isClosedForReceive) { | ||
| val receiveResult = channel.receiveCatching() | ||
| receiveResult.onSuccess { | ||
| attachment.document.publishEvent(StreamConnectionChange.Connected) |
There was a problem hiding this comment.
don't we need this line?
if the stream fails then succeed on retry, users would not receive the connected state.
There was a problem hiding this comment.
I missed it. fixed in 4f46596
skhugh
approved these changes
May 17, 2024
|
Some tests are failing in the CI, but I checked they're working fine with the real server. I'll investigate these failing tests after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist