Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for invalid range #59

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add a test case for invalid range #59

wants to merge 5 commits into from

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Feb 28, 2023

What this PR does / why we need it:
Add a test case for an invalid range from remote selection

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum added the bug 🐞 Something isn't working label Feb 28, 2023
@humdrum humdrum self-assigned this Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #59 (cea91c6) into main (5f123d8) will decrease coverage by 0.35%.
The diff coverage is 7.29%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   59.77%   59.42%   -0.35%     
==========================================
  Files          91       91              
  Lines       13268    13356      +88     
==========================================
+ Hits         7931     7937       +6     
- Misses       5337     5419      +82     
Impacted Files Coverage Δ
Sources/Document/Json/JSONText.swift 54.66% <0.00%> (-1.12%) ⬇️
Sources/Util/String+Extensions.swift 68.42% <0.00%> (-31.58%) ⬇️
Tests/Integration/ClientIntegrationTests.swift 0.83% <0.00%> (ø)
Tests/Integration/CounterIntegrationTests.swift 0.72% <0.00%> (ø)
Tests/Integration/TextIntegrationTests.swift 1.36% <1.31%> (-0.02%) ⬇️
Sources/Document/CRDT/RGATreeSplit.swift 79.76% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant