Enhance type inference in Document.subscribe #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
+ Coverage 80.74% 80.81% +0.07%
==========================================
Files 59 59
Lines 4481 4477 -4
Branches 908 905 -3
==========================================
Hits 3618 3618
+ Misses 601 599 -2
+ Partials 262 260 -2 ☔ View full report in Codecov by Sentry. |
hackerwins
force-pushed
the
type-infer-doc-event
branch
4 times, most recently
from
63fbc54
to
4712007
Compare
hackerwins
force-pushed
the
type-infer-doc-event
branch
from
4712007
to
29685f6
Compare
hackerwins
approved these changes
May 20, 2024
hackerwins
changed the title
doc.subscribe() to infer event types appropriately based on the topic
hackerwins
added a commit
that referenced
this pull request
May 20, 2024
This commit improves the type inference for the types used in Document.subscribe. Additionally, it removes the code that forces casting in the test code to align with these improvements. --------- Co-authored-by: Hackerwins <susukang98@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
doc.subscribe()to infer event types appropriately based on the topicTODO(chacha912): Remove any type after specifying the type of DocEventDocEvent.Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist