Fix request variables validation #239
Open
+86
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 13, 2020 16:28
The error checking should be done in RequestValidator instead, and it already takes care of this use case
Jalle19
commented
Jan 13, 2020
| $this->assertEquals([ | ||
| 'errors' => [ | ||
| [ | ||
| 'message' => 'Variable "episode" does not exists', |
There was a problem hiding this comment.
@leoloso this is the error you expect, right?
There was a problem hiding this comment.
I think the more important error is that the variable is not defined in the operation name, which is mandatory in GraphQL. Hence the error should be something like Variable "episode" has not been defined in the operation name
|
Hmm, this is going to need some more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238