Add label matching according to RFC 1123 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaeberle
suggested changes
Jul 5, 2023
| for example 'my-name', or '123-abc' | ||
| """ | ||
|
|
||
| RFC_1123_LABLE_REGEX = r"[a-zA-Z0-9]([-a-zA-Z0-9]*[a-zA-Z0-9])?$" |
There was a problem hiding this comment.
There is a little typo in your variable naming:
Suggested change
| RFC_1123_LABLE_REGEX = r"[a-zA-Z0-9]([-a-zA-Z0-9]*[a-zA-Z0-9])?$" | |
| RFC_1123_LABEL_REGEX = r"[a-zA-Z0-9]([-a-zA-Z0-9]*[a-zA-Z0-9])?$" |
|
|
||
| @property | ||
| def _regex(self): | ||
| return re.compile(self.RFC_1123_LABLE_REGEX) |
There was a problem hiding this comment.
Tpyo:
Suggested change
| return re.compile(self.RFC_1123_LABLE_REGEX) | |
| return re.compile(self.RFC_1123_LABEL_REGEX) |
|
I think this would be also helpful when validating a single hostname (without any domain) for RFC1123 conformance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature could be helpful to check the RFC 1123 Label standard.
One of the major use-cases is checking strings to be valid for
Kubernetes Namespace.Thanks for your attention. I hope it will be helpful for you folks.