Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/taptap] Add extractors #9776

Merged
merged 10 commits into from May 23, 2024
Merged

[ie/taptap] Add extractors #9776

merged 10 commits into from May 23, 2024

Conversation

c-basalt
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Add support for video extraction from taptap.cn posts and game topic pages

Fixes #9643

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-request Request to support a new website label Apr 27, 2024
Copy link
Collaborator

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a complete review, but more some initial feedback.

yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label May 9, 2024
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Show resolved Hide resolved
yt_dlp/extractor/taptap.py Show resolved Hide resolved
yt_dlp/extractor/taptap.py Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
c-basalt and others added 4 commits May 22, 2024 01:50
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels May 22, 2024
@bashonly bashonly self-requested a review May 22, 2024 22:38
yt_dlp/extractor/taptap.py Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
c-basalt and others added 2 commits May 23, 2024 01:45
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
@Grub4K Grub4K removed the pending-review PR needs a review label May 23, 2024
yt_dlp/extractor/taptap.py Outdated Show resolved Hide resolved
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev seproDev changed the title [ie/taptap] Add new extractor for taptap.cn [ie/taptap] Add extractors May 23, 2024
@seproDev seproDev merged commit 63b569b into yt-dlp:master May 23, 2024
6 checks passed
@c-basalt c-basalt deleted the taptap branch May 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site request: taptap.cn
4 participants