Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/eplus] Check if it's a pass ticket url; replace a dead url in test #9855

Merged
merged 3 commits into from May 13, 2024

Conversation

pzhlkj6612
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Summary

Related to #9515.

An "ex/player" url without "show_id" points to either a player page or a collection of multiple player page urls.

Question

Maybe we should change the regex to https?://live\.eplus\.jp/ex/player\?ib=.+ ?

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pzhlkj6612
Copy link
Contributor Author

For 113758d , here are the test urls:

Comparison:

- Pass ticket index
+ Player page

  data_json = {
    "delivery_status": "...",
  
-   "archive_mode": null,
-   "is_pass_ticket": "YES",
+   "archive_mode": "ON",
+   "is_pass_ticket": "NO",
  
    "app_id": "...",
    "app_name": "...",
    "drm_mode": null
  }

.

@pzhlkj6612 pzhlkj6612 changed the title [ie/eplus] Fix test: replace a dead url; add a pass ticket url [ie/eplus] Check if it's a pass ticket url; replace a dead url in test May 4, 2024
@seproDev seproDev added the site-bug Issue with a specific website label May 4, 2024
@pzhlkj6612
Copy link
Contributor Author

While there is some metadata in the pass ticket page, I don't think it makes much sense to extract it since there must not be any playable media. Any opinion?

@bashonly
Copy link
Member

bashonly commented May 9, 2024

I don't think it makes much sense to extract it since there must not be any playable media

Agreed, I wouldn't worry about it

yt_dlp/extractor/eplus.py Outdated Show resolved Hide resolved
yt_dlp/extractor/eplus.py Outdated Show resolved Hide resolved
@bashonly bashonly merged commit 351dc0b into yt-dlp:master May 13, 2024
6 checks passed
@pzhlkj6612 pzhlkj6612 deleted the ie/eplus/test branch May 14, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants