New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/crunchyroll] Make additional audio languages available #9867
base: master
Are you sure you want to change the base?
Conversation
It's incompatible with the hardsub code
@Grub4K - you are maintaining this IE, correct? |
I'm curious: what is the use case for querying the information for up to eight or even more languages a video is available for, when I'm most probably only interested in exactly the video I've selected? Each query is another network request... |
I'm not quite sure what this PR is trying to accomplish but the current default is disgustingly slow with the amount of requests it makes so I'm using a closed PR from ProDev2 that added language selection so it only requests the language I specify (https://github.com/Jules-A/yt-dlp/tree/cr-langs if you want to try it). Grub4K seems obsessed on keeping such stuff to a useless plugin that no-one will end up using so don't know if language selection will ever officially return. |
The link that gets copied from the web app is the one with Japanese audio, and there was no option to change the audio.
I can rewrite it as an extractor argument like the hardsub option, I felt that offering more options available for the Format List was more natural from a user in search of a dub perspective. |
Hmm. Not for me.
But that's probably offtopic here. |
Same story here: $ yt-dlp --login --print language https://www.crunchyroll.com/watch/GK9U3KPKW
ja-JP
$ yt-dlp --login --print language https://www.crunchyroll.com/watch/G0DUNKEKJ
en-US
No, this is a valid concern, and exactly the reason why I did not want to implement this before, since doing so will either break the download archive or, like in this case, playlist filtering. It's a lose-lose in that case. Problem: I think there were cases where passing different urls (the changed one after language change) would turn out the same language version. If someone can provide an example where it doesnt work as expected, please show it here so we can re-evaluate. The only way I can think off that will solve this while maintaining compatiblity is this:
Having said that, I am not completely opposed an extractor arg to force language, given that @pukkandan agrees that it is okay that the download archive breaks when providing an extractor arg. Alternatively, Grub4K@96b2919 can still be merged to reduce playlist queries without impacting compat |
I believe this is the ideal solution and is similar to how I had implemented funimation before. Does this have any drawbacks except for complexity? |
No, not as far as I can tell, however nobody took the time to properly implement it yet. Since I cannot reproduce, didn't get sent any reproduction cases (cough cough), it's a fair effort, AND will change the ids used I was hesitant to implement it myself |
Description of your pull request and other information
Fetch additional audio languages for crunchyroll streams if available.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?