Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse YT-EXT-AUDIO-CONTENT-ID for multiple language detection in YouTube HLS Manifests. #9875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clienthax
Copy link
Contributor

@clienthax clienthax commented May 6, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Properly parse YT-EXT-AUDIO-CONTENT-ID when present in HLS manifests to determine correct audio streams.
Fixes ability to specify languages for YouTube when using hls manifests with the following arguments which would otherwise just fall back to the first entry.

Some additional logic may be required to return the 'original' audio when no language is defined?

yt-dlp -f mp4[height<=?1080][language=en]/best[height<=?1080][language=en] --verbose --list-formats --no-cache-dir --rm-cache-dir --get-url --impersonate safari https://www.youtube.com/watch?v=4ofJpOEXrZs

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan added the site-enhancement Feature request for some website label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

2 participants