New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/beacon] Add extractor for Beacon.tv #9901
base: master
Are you sure you want to change the base?
Conversation
Abandoning, as I just realized there's a way cleaner method to do what it needs to do. |
You can push to the same branch and repurpose/reopen this PR |
Nevermind the earlier message. I tried to use the Beacon API at https://beacon.tv/api/graphql. This works generally, and would simplify the flow of the code a lot. Unfortunately, for authenticated requests this requires an authentication token. This token is not retrievable from cookies, and requires a fairly complicated Oauth flow (using Memberful, a Wordpress plugin). This flow involves captions and other annoyances I wasn't able to work around. While the direct API handling would have been a lot nicer, scraping the information from the HTML also functions. As such this should be fine for now. |
I get some errors for their "Cooldown" series. Here is an example output:
|
Thanks for the heads up, should be fixed now! If Beacon does not explicitly set the language on a subtitle, we now default it to English. |
Great, I've tested it and it is working now, thank you for the work and the quick response! |
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Add an extractor to support downloading from https://beacon.tv, a new media website launched by Critical Role yesterday.
This website places a JSON in an HTML tag with a specific ID and type. This tag is extracted, the JSON is parsed, and the m3u8 URL and metadata are retrieved from the JSON.
Authentication on the site is done through cookies. This means that downloading videos that require authentication currently depends on the --cookies-from-browser command line flag. Videos that are public can be downloaded without this flag.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?