New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/GoogleDrive] Add more supported types #9908
Conversation
also in the future please do not force push, all commits will be squashed upon merge |
Had to force some, wrong identity as I am not on my laptop. |
Ok I have trouble matching the md5sum: -f 50 e94c9cbb9cf9c9724f71ce53141d5a2f However:
|
use the value that the test script gives you. It is only hashing the first 10B of the file |
Ok we're clear, the test passes. Thanks a lot for your help and time! |
We import those from the Youtube extractor, and also add: '50':'mp3', for mp3 files scrapping. Fix: yt-dlp#8281
please stop force pushing, you vaporized my changes also, when I download format 50 and ffprobe it, it says it is m4a/aac |
Hmmm indeed:
So the source file is mp3, Google converts it in m4a, well sorry about that. Curious that some files work an others don't though. |
I don't think google/youtube encodes anything in mp3 |
[extractor/GoogleDrive] Add more supported types
We import those from the Youtube extractor, and also add:
for mp3 files scrapping.
Fixes #8281
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?