Fix #1740: Scrollview scrolltoindex breaks after a click-drag down #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've come across the problem described in yui#1740 and found out that this is happening because _beforeHostScrollTo is always trying to adjust the scroll coordinates according to the last gesture that was made. It's possible that the scrolling wasn't caused by a gesture though, like on direct calls to scrollToIndex (the buttons on http://yuilibrary.com/yui/docs/scrollview/scrollview-paging-example.html for example). And if this is done right after a gesture which is not on the scrolling axis, _beforeHostScrollTo will clear the coordinates, which is why the index is being changed but the new image is not being scrolled into view. I've fixed this by making sure that _beforeHostScrollTo doesn't try using the last gesture to adjust the coordinates for a call to scrollToIndex, since this call will already have the right coordinate anyway.
|
CLA is valid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across the problem described in #1740 and found out that this is happening because _beforeHostScrollTo is always trying to adjust the scroll coordinates according to the last gesture that was made.
It's possible that the scrolling wasn't caused by a gesture though, like on direct calls to scrollToIndex (the buttons on http://yuilibrary.com/yui/docs/scrollview/scrollview-paging-example.html for example). And if this is done right after a gesture which is not on the scrolling axis, _beforeHostScrollTo will clear the coordinates, which is why the index is being changed but the new image is not being scrolled into view.
I've fixed this by making sure that _beforeHostScrollTo doesn't try using the last gesture to adjust the coordinates for a call to scrollToIndex, since this call will already have the right coordinate anyway.