Inheritted group combo params #1838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng is specified This fixes a regression caused by yui#1832.
|
CLA is valid! |
|
I've added tests for combine, and comboSep, but I wasn't sure how best to test that maxURLLength is applied differently within groups. |
| comboBase = group.comboBase; | ||
| comboSep = group.comboSep; | ||
| maxURLLength = group.maxURLLength; | ||
| if (typeof group.comboBase === 'string') { |
There was a problem hiding this comment.
Do we care about comboBase: ''?
There was a problem hiding this comment.
Why wouldn't we? It should be possible to either specify a comboBase for a group, or to use the inheritted one. There are reasons you may want to do so, largely developer related admittedly.
There was a problem hiding this comment.
I don't have a personal stance in this case. But should we stick to backwards compatibility ('' being falsy)?
There was a problem hiding this comment.
guys, let's stick to the previous behavior, there is not need to change that behavior now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the fix for #1837