Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ビルドが通るようにした #162

Merged
merged 2 commits into from
May 19, 2023
Merged

ビルドが通るようにした #162

merged 2 commits into from
May 19, 2023

Conversation

emrum01
Copy link
Collaborator

@emrum01 emrum01 commented May 18, 2023 •
edited

概要

検証方法:
yarn buildが通ること

@emrum01 emrum01 requested a review from taka10257 May 18, 2023 23:23
@emrum01 emrum01 mentioned this pull request May 18, 2023
Merged
@emrum01 emrum01 changed the title reactのバージョンと型を合わせた reactのバージョンと型noを合わせた May 18, 2023
@emrum01 emrum01 changed the title reactのバージョンと型noを合わせた reactのバージョンと型のバージョンを合わせた May 18, 2023
@emrum01 emrum01 self-assigned this May 18, 2023
@emrum01 emrum01 changed the title reactのバージョンと型のバージョンを合わせた ビルドが通るようにした May 18, 2023
taka10257
taka10257 approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@taka10257 taka10257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます！
一通りマージした状態で確認してみるのでApproveします！
LGTM

@emrum01 emrum01 merged commit c0e8239 into master May 19, 2023
@emrum01 emrum01 deleted the chore/fix-to-pass-build branch May 19, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taka10257 taka10257 taka10257 approved these changes

Assignees

@emrum01 emrum01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emrum01 @taka10257