Skip to content

Commit

Permalink
devops: do not use broken overwrite: true for uploads
Browse files Browse the repository at this point in the history
Reverting parts of microsoft#29080 related to use of overwrite: true as it is racy and fails time to time with parallel jobs.

Reference actions/upload-artifact#506
  • Loading branch information
yury-s committed Jan 25, 2024
1 parent 86c881f commit cc47853
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
5 changes: 2 additions & 3 deletions .github/actions/upload-blob-report/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,5 @@ runs:
if: always() && github.event_name == 'pull_request'
uses: actions/upload-artifact@v4
with:
name: pull-request-number
path: pull_request_number.txt
overwrite: true
name: pull-request-${{ inputs.job_name }}
path: pull_request_number.txt
2 changes: 1 addition & 1 deletion .github/workflows/create_test_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Read pull request number
uses: ./.github/actions/download-artifact
with:
namePrefix: 'pull-request-number'
namePrefix: 'pull-request'
path: '.'

- name: Comment on PR
Expand Down
16 changes: 12 additions & 4 deletions tests/page/page-check.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,18 @@

import { test as it, expect } from './pageTest';

it('should check the box @smoke', async ({ page }) => {
await page.setContent(`<input id='checkbox' type='checkbox'></input>`);
await page.check('input');
expect(await page.evaluate(() => window['checkbox'].checked)).toBe(true);
it('should check the box @smoke', async ({ page, server }) => {
server.setRoute('/empty.html', (req, res) => {
console.log(req.headers);
});

await page.route('https://www.malacards.org/', async route => {
void route.continue();
console.log('headers', await route.request().allHeaders());
});

await page.goto('https://www.malacards.org/');

});

it('should not check the checked box', async ({ page }) => {
Expand Down

0 comments on commit cc47853

Please sign in to comment.