Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding of publish command, publishing type is optional #59

Merged
merged 1 commit into from Jul 19, 2023

Conversation

jbreich
Copy link
Contributor

@jbreich jbreich commented Jul 12, 2023

I have noticed that some tools are not providing the publishing type in the publish command. It is not explicitly optional in the specification but in practice it seems to be. And so by default I use the live value

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.05 🎉

Comparison is base (73d0006) 62.55% compared to head (f76554c) 62.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   62.55%   62.61%   +0.05%     
==========================================
  Files          36       36              
  Lines        1896     1899       +3     
==========================================
+ Hits         1186     1189       +3     
  Misses        569      569              
  Partials      141      141              
Flag Coverage Δ
unittests 62.61% <50.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
message/body_decoder.go 48.86% <50.00%> (+0.88%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@yutopp yutopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! LGTM, so I'd like to proceed with the merge. By the way, would you be able to tell me the names of such tools that issue the publish command, just for reference?

Thank you.

@jbreich
Copy link
Contributor Author

jbreich commented Jul 17, 2023

Hello,
Unfortunately I don't know exactly what is pushing that... from the information I have it is coming from an extron electronics (hardware equipment) through the restream SaaS platform. But I don't know exactly who is not providing the publishingType

@yutopp
Copy link
Owner

yutopp commented Jul 19, 2023

I see, thank you very much. It's intriguing, so I think I'd like to investigate based on the information you've provided.

@yutopp yutopp merged commit 2ae4e86 into yutopp:master Jul 19, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants