MI2 backslashes #2155
Open
MI2 backslashes #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do I test it from UI perspective? Place & hit a breakpoint? What's the IDE? Ideally I'd appreciate a repo with just the test case. |
|
For me I am using the Native Debug extension in vscode. It sends escaped requests and works fine, but the reply for when the breakpoint gets hit is not escaped, so it gets confused |
|
It's difficult for me to provide an example at the moment due to #2154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MI2 interpreter doesn't escape backslashes in the response which, you guessed it, causes problems with Windows. Now all filenames are escaped. Also fixed another colon scan problem in the symbols.
This PR is based on #2153 because I needed the fixes in there to debug further.