GraphQL v16 compatibility

[ardatan]

GraphQL v16 has been released recently so this PR does the following changes for the compatibility;

• Type resolvers no longer returns type itself but the name of the type because this no longer supported in v16
• Update TS version because v16 doesn't support existing version
• Add tests for both v15 and v16
• Use the custom implementation of collectFields in json.ts because it has been changed in v16
• Fix typing issues
• Use isSubType instead of isPossibleType because it has been removed in v16
• Replace toEqual with toMatchObject to compare results because GraphQLError is no longer serialized like JSO
• Remove Node 10 from CI because v16 doesn't support it and it has been no longer maintained.
• Update TS version to support latest changes and v16
• Migrate to ESlint and update Prettier to support new TypeScript ESLint plugin

[ardatan]

Is there anything missing to get this merged?

[ardatan]

Sorry it is my bad :( Could you run it again? @boopathi

[ardatan]

I hate to ask but I need another :) Is it possible to make this automatic only for this PR ? @boopathi

[ardatan]

I removed Node 10 because v16 doesn't support it and it has been no longer maintained. @boopathi That's why CI failed :/

[ruiaraujo]

@ardatan switch from node 15 to node 16 on the build.

[dotansimha]

@ruiaraujo @boopathi @topicus can you please review this PR? seems like it's breaking on other tools as well (envelop / graphql-mesh) and blocks the ability to upgrade.

[ardatan]

@ruiaraujo Done!

[ardatan]

@ruiaraujo I also ran prettier and ts-lint to fix format/lint issues.

[ruiaraujo]

@ardatan the build is still complaining about the formatter.

[ardatan]

@ruiaraujo Prettier's TSLint plugin fails because TSLint doesn't know about the following syntax;

} catch(e: any) { //Casting errors which necessary for TS

While we need the syntax above for TS v4
TS v4 is needed for GraphQL v16 but TS v4 isn't supported by TSLint
TSLint is deprecated and should be replaced with ESLint.

I can do that in this PR?

[ruiaraujo]

@ardatan yes

[ruiaraujo]

@ardatan we also need to conver https://github.com/zalando-incubator/graphql-jit/blob/master/tslint.json to eslint.json

[ardatan]

I think rules are fine now since TSLint rules don't exist as-is in ESLint.
Update: I converted them anyway and I updated prettier so I needed to configure trailingCommas there.

[ruiaraujo]

@ardatan almost there, you're getting closer. 😄

[ardatan]

I hope this time it will pass @ruiaraujo :)

[ruiaraujo]

👍

[ardatan]

I think you need to update repo settings for "Expected" workflows

[ruiaraujo]

@ardatan we will do it when we are ready to merge with the second review, no worries. Thanks for the great contribuition.

[addityasingh]

@ardatan can you fix the conflicts since we merged your other PR #139 ?

[ardatan]

Done @addityasingh @ruiaraujo @boopathi

[ruiaraujo]

👍

[ardatan]

@ruiaraujo @boopathi @topicus @addityasingh When could this get merged and released? We really need this for our libraries in order to upgrade to GraphQL v16 :/

[oporkka]

Will tslint dependencies still be needed even if we move to eslint?

[ardatan]

Nice catch! Removed!

[oporkka]

I'll keep it open until the change is pushed, for visibility

[ardatan]

My bad :) I forgot to push

[ardatan]

Could you take a look if it is good for you? @oporkka

[ruiaraujo]

👍

[oporkka]

👍

[ardatan]

Thank you <3