[RFC] compile createSourceEventStream #153
Open
+336
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `createSourceEventStream` to the `CompiledQuery`. Signed-off-by: Georg Bremer <github@dschoordsch.de>
Add a benchmark to show it's worth exposing the function. Signed-off-by: Georg Bremer <github@dschoordsch.de>
The use case for createSourceEventStream is running the event stream and resolvers in different processes. That means compiling the resolvers is not necessary and just costs performance. Signed-off-by: Georg Bremer <github@dschoordsch.de>
|
@markrzen could you take a look and let me know if this is something you would be willing to accept? If yes, I will polish it up. |
|
Hey @Dschoordsch, I am not a maintainer of the library. You will want to ping the good folks on this list: |
|
I wont have time before the weekend to check it. |
|
@ruiaraujo did you have chance to take a look whether or not a |
|
@boopathi could you take a look if that's something which you would be interested in? |
Dschoordsch
changed the title
|
@Dschoordsch We would like to learn if there are more needs for this in the GraphQL JIT user community |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a source event stream from the compiled query is about 1.5 to 2 times faster. The use case for createSourceEventStream is running the event stream and resolvers in different processes. That means compiling the resolvers is not necessary and just costs performance, thus a separate function is exposed for just this use case.
It does not actually compile anything, but that's an implementation detail und thus
compileCreateSourceEventStreamname was chosen.This needs some polishing and tests, but I would like to know if you're interested in this at all?
Relates-To: ParabolInc/parabol#5468