Add PlatformCredentialsSet API client #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing for the implementation of the PlatformCredentialsSet per Stack feature, this commit adds PlatformCredentialsSet to the zalando.org/v1 api. Signed-off-by: Katyanna Moura <amelie.kn@gmail.com>
Signed-off-by: Katyanna Moura <amelie.kn@gmail.com>
|
@katyanna I think you also need to add the new types here: |
Signed-off-by: Katyanna Moura <amelie.kn@gmail.com>
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
|
👍 |
mikkeloscar
reviewed
Feb 9, 2024
| Errors []string `json:"errors"` | ||
| Problems []string `json:"problems"` | ||
| Tokens map[string]struct{} `json:"tokens"` | ||
| Clients map[string]struct{} `json:"clients"` |
There was a problem hiding this comment.
Ideally we should have proper types defined here, but it's probably not relevant for the implementation in stackset.
There was a problem hiding this comment.
This actually fails with
/masked/github.com/zalando-incubator/stackset-controller/pkg/apis/zalando.org/v1/types_pcs.go:47:32: not a supported map value type: *ast.StructType
/masked/github.com/zalando-incubator/stackset-controller/pkg/apis/zalando.org/v1/types_pcs.go:48:32: not a supported map value type: *ast.StructType
Error: not all generators ran successfullybut the failure is masked by || /bin/true || true:
Line 38 in 2bcb26c
introduced ages ago by #182
Maybe it was necessary back then but now I think it is not, I tried to clean build a commit before this one (2104a96) with updated Makefile (used old go version due to #610)
diff --git a/Makefile b/Makefile
index ecd5ca5..5e4ea29 100644
--- a/Makefile
+++ b/Makefile
@@ -35,7 +35,7 @@ $(GENERATED): go.mod $(CRD_TYPE_SOURCE)
./hack/update-codegen.sh
$(GENERATED_CRDS): $(GENERATED) $(CRD_SOURCES)
- go run sigs.k8s.io/controller-tools/cmd/controller-gen crd:crdVersions=v1,allowDangerousTypes=true paths=./pkg/apis/... output:crd:dir=docs || /bin/true || true
+ ~/bin/go1.21.5/bin/go run sigs.k8s.io/controller-tools/cmd/controller-gen crd:crdVersions=v1,allowDangerousTypes=true paths=./pkg/apis/... output:crd:dir=docsand it seems to work (not sure why it adds x-kubernetes-map-type: atomic everywhere though, maybe due to kubernetes-sigs/controller-tools#753)
There was a problem hiding this comment.
Here is an improvement of this: #614
|
👍 |
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 12, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 12, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 12, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for the implementation of the PlatformCredentialsSet per Stack feature,
this Pull Request adds
PlatformCredentialsSetto the zalando.org/v1 api.