Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logbook-spring RemoteResponse code #1672

Closed

Conversation

luc-leclerc
Copy link
Contributor

@luc-leclerc luc-leclerc commented Nov 12, 2023

Description

  • Removed use of state.

Motivation and Context

  • A lot of code and classes for a feature that is not documented or tested.
  • One of the inner private class was unused.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Copy link
Contributor

In order to prioritize the support for Logbook, we would like to check whether the old pull-requests are still relevant.
This pull-request has not been updated for over six months.

  • Please check if it is still relevant in latest version of the Logbook.
  • If so, please update the pull-request based on the latest main branch.
  • Otherwise, the pull-request will automatically be closed after a week.

@github-actions github-actions bot added the stale label May 20, 2024
Copy link
Contributor

This pull-request has automatically been closed due to no activities. If it is still relevant, please feel free to re-open it. Don't forget to use the latest main branch.

@github-actions github-actions bot closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant