Names to container ports for postgresql, patroni and operator #2234
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacksegv
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda and
hughcapet
as code owners
|
I'm fine with this change. Note, that it will trigger a rolling update of all database pods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about to get prometheus-operator fetch the metrics of the patroni metrics endpoint.
The prometheus operator CR for podmonitor definition of the endpoint only supports port names and no numbers.
So adding names for the container ports should IMHO not interfere with any component, but i surely may be corrected and there are no names for reasons.
If there shall be any documentation to be extended, i'd go for it - i did not find a good place for it.
The DOCKER_CLI Variable makes it possible to use e.g. nerdctl for container build.
This is my first PR of all time - please be gracious :-D