Change SecurityProblemSupport bean after AdviceTrait created #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cause, HandlerExceptionResolver created by WebMvcAutoConfiguration, but ProblemSecurityAutoConfiguration created before WebMvcAutoConfiguration. Import(SecurityProblemSupport) annotation working before created HandlerExceptionResolver. If you don't define custom AdviceTrait bean, it doesn't well working. So SecurityProblemSupport bean depends on AdviceTrait bean
aafwu00
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecurityProblemSupport bean depends on AdviceTrait bean
Description
HandlerExceptionResolver created by WebMvcAutoConfiguration, but ProblemSecurityAutoConfiguration created before WebMvcAutoConfiguration.
Import(SecurityProblemSupport) annotation working before created HandlerExceptionResolver.
If you don't define custom AdviceTrait bean, it doesn't well working.
So this patch fix problem.
Motivation and Context
This fixes #707
Types of changes
Checklist: