Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sort example from simple query language (236) #804

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ePaul
Copy link
Member

@ePaul ePaul commented Apr 11, 2024

The sort=id:desc example doesn't fit the "equality comparison for a logical property".

It also leads to confusion on how to indicate how the result should be sorted (rule 137 says sort=-id).

This replaces it with another "logical property", the age (which is often calculated from the birthday and current date).

(Triggered by an internal chat message.)

The `sort=id:desc` example doesn't fit the "equality comparison for a logical property".

It also leads to confusion on how to indicate how the result should be sorted (rule 137 says `sort=-id`).

This replaces it with another "logical property", the age (which is often calculated from the birthday and current date).
@rishiraj88
Copy link

For sort order, 'asc' and 'dec' may make good sense. I am not sure whether we are curious about 'desc' to mean "decreasing". Is it a case here?

@ePaul
Copy link
Member Author

ePaul commented Apr 11, 2024

@rishiraj88

For sort order, 'asc' and 'dec' may make good sense. I am not sure whether we are curious about 'desc' to mean "decreasing". Is it a case here?

desc (for "descending") might make sense, but it doesn't fit into the query language rule (as it's not a filter – unless you are querying a list of queries or similar), and it also contradicts the earlier rule 137 about the + or - prefix (and we want to be consistent).

@tfrauenstein
Copy link
Member

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented Apr 16, 2024

👍

@ePaul ePaul merged commit 0655968 into main Apr 16, 2024
2 checks passed
@ePaul ePaul deleted the remove-sort-id-desc branch April 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants