Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/redistest: update go-redis client to work with redis:6 #2949

Merged
merged 1 commit into from Feb 20, 2024

Conversation

AlexanderYastrebov
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov commented Feb 20, 2024

Update https://github.com/redis/go-redis/releases/tag/v9.5.0 broke support of redis:6

Unfortunately we did not catch it because we updated test redis to redis:7 recently, see #2895

This change adds test to verify client supports both redis:6 and redis:7

The issue seems to be redis/go-redis#2915

Update https://github.com/redis/go-redis/releases/tag/v9.5.0
broke support of redis:6

Unfortunately we did not catch it because we updated test redis to
redis:7 recently, see #2895

This change adds test to verify client supports both redis:6 and redis:7

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov added the bugfix Bug fixes and patches label Feb 20, 2024
@@ -12,14 +12,23 @@ import (
"github.com/testcontainers/testcontainers-go/wait"
)

type options struct {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided not to export for now

@@ -15,3 +15,13 @@ func TestRedistest(t *testing.T) {
t.Fatalf("Failed to ping redis: %v", err)
}
}

func TestRedistestRedis6(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes for 9.4.0 and 9.5.1 but fails for 9.5.0

@szuecs
Copy link
Member

szuecs commented Feb 20, 2024

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes and patches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants