Added max-unhealthy-endpoints-ratio cmdline parameter for PHC #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanZavodskikh
added
the
major
szuecs
reviewed
May 14, 2024
szuecs
reviewed
May 14, 2024
szuecs
reviewed
May 14, 2024
szuecs
reviewed
May 14, 2024
szuecs
reviewed
May 14, 2024
szuecs
reviewed
May 14, 2024
szuecs
reviewed
May 14, 2024
RomanZavodskikh
force-pushed
the
maxUnhealthyEpsRatio
branch
from
f3f79f4
to
92733fa
Compare
RomanZavodskikh
force-pushed
the
maxUnhealthyEpsRatio
branch
from
92733fa
to
9aaf368
Compare
RomanZavodskikh
force-pushed
the
maxUnhealthyEpsRatio
branch
2 times, most recently
from
fb4beba
to
dc87ad2
Compare
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
force-pushed
the
maxUnhealthyEpsRatio
branch
from
dc87ad2
to
fe2d024
Compare
|
👍 |
2 similar comments
|
👍 |
|
👍 |
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is nice to have because PHC feature was designed to mitigate some small amount of unhealthy endpoints.
So, it is better to fail open if the amount of unhealthy endpoints is "too much".
The introduced parameter configures this "too much".