-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization of font-family #143
base: master
Are you sure you want to change the base?
Conversation
@bocytko Any chance to get this merged? :) |
Thanks for pointing out the missing configuration. What's the likelihood of a font-family change requiring a subsequent font-size change? In the end also the magic number offsets are related to the font sizes, which would complicate matters.
Please open an issue for that and suggest how it could be achieved. If it does not end up being too ugly, I'd consider accepting a PR. |
Good point, I guess with some font-families it might lead to issues, and as you pointed out making all the font-size combinations adjustable leads to more complexity. Maybe I could add a comment indicating that changing the font-family might lead to subsequent readability challenges ("change at your own risk")?
Here a short comparison between Arial and Source Sans Pro: ArialSource Sans Pro |
Short comment sounds good. You can also mention 1-2 alternate font families that are compatible with current settings. |
ede9ade
to
3749a97
Compare
3749a97
to
3615a4c
Compare
Apologies for the delay, added a comment to the example in the README and defined a default value. |
Currently the radar SVG has its font-family hardcoded, with this PR it becomes customizable.
I noticed that
radar.css
prefers Source Sans Pro for the surrounding text. Let me know if I should also adjust that or you'd like to handle it separately.