Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selenium: add Stealth feature to avoid automation detection #4981

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

double16
Copy link
Contributor

@double16 double16 commented Oct 9, 2023

Overview

When running Chrome via Selenium, try to hide that Chrome is being driven by web driver. Some sites/pages detect such as will not serve the page.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits (single commit)
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

@thc202 thc202 changed the title Add Stealth feature to Selenium to avoid automation detection selenium: add Stealth feature to avoid automation detection Oct 9, 2023
@double16 double16 marked this pull request as draft October 11, 2023 12:31
@double16 double16 marked this pull request as ready for review October 11, 2023 16:23
@kingthorin
Copy link
Member

To address the DCO requirement you'll need to sign-off the commit(s):


Note there’s also a code scanning result which should be addressed.

@double16
Copy link
Contributor Author

double16 commented Jan 9, 2024

To address the DCO requirement you'll need to sign-off the commit(s):

* https://github.com/zaproxy/zaproxy/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

* https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff

Note there’s also a code scanning result which should be addressed.

I looked through the commits using the Commits tab and they all showed Verified... signed by myself.

@kingthorin
Copy link
Member

Signed and signed off are different things for Git.

Copy link

github-actions bot commented Feb 23, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@double16
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA
recheck

@thc202
Copy link
Member

thc202 commented Feb 23, 2024

The comment needs to exactly match I have read the CLA Document and I hereby sign the CLA (i.e. without recheck).

@double16
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

zapbot added a commit to zaproxy/cla that referenced this pull request Feb 23, 2024
Signed-off-by: Patrick Double <pat@patdouble.com>
Signed-off-by: Patrick Double <pat@patdouble.com>
Signed-off-by: Patrick Double <pat@patdouble.com>
Signed-off-by: Patrick Double <pat@patdouble.com>
Signed-off-by: Patrick Double <pat@patdouble.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants