Skip to content

Commit

Permalink
Pin Vue language server to 1.8 (#9846)
Browse files Browse the repository at this point in the history
After `@vue/language-server` release 2.0, vue lsp doesn't work. I tried
to support 2.0, but since I'm not familiar with `@vue/language-server`
and `zed` I was unsuccessful. To avoid long-term unavailability, I
temporarily fixed the version to 1.8 until we have 2.0 support.

Release Notes:

- Pinned `@vue/language-server` to version `1.8` until Zed supports
`2.x`. ([#9388](#9388) &
[#9329](#9329)).

---------

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
  • Loading branch information
Dunqing and mrnugget committed Mar 27, 2024
1 parent de4a54a commit 96b812b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions crates/languages/src/vue.rs
Expand Up @@ -48,10 +48,8 @@ impl super::LspAdapter for VueLspAdapter {
_: &dyn LspAdapterDelegate,
) -> Result<Box<dyn 'static + Send + Any>> {
Ok(Box::new(VueLspVersion {
vue_version: self
.node
.npm_package_latest_version("@vue/language-server")
.await?,
// We hardcode the version to 1.8 since we do not support @vue/language-server 2.0 yet.
vue_version: "1.8".to_string(),
ts_version: self.node.npm_package_latest_version("typescript").await?,
}) as Box<_>)
}
Expand Down

0 comments on commit 96b812b

Please sign in to comment.