Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to disable highlighting of current line #5222

Closed
1 task done
chriskrycho opened this issue Sep 10, 2022 · 0 comments · Fixed by #11710
Closed
1 task done

Ability to disable highlighting of current line #5222

chriskrycho opened this issue Sep 10, 2022 · 0 comments · Fixed by #11710
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label]

Comments

@chriskrycho
Copy link

Check for existing issues

  • Completed

Is your feature request related to a problem?

Current line highlighting is great, but I don't always want it! Especially when writing vs. coding.

Describe the solution you'd like

A flag to disable the current line highlight.

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@chriskrycho chriskrycho added enhancement [core label] triage Maintainer needs to classify the issue labels Sep 10, 2022
@JosephTLyons JosephTLyons added editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue labels Sep 10, 2022
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@Moshyfawn Moshyfawn mentioned this issue May 8, 2024
Closed
1 task
@alygin alygin mentioned this issue May 11, 2024
Merged
SomeoneToIgnore pushed a commit that referenced this issue May 13, 2024
@alygin
editor: Current line highlight options (#11710)
8e92f19 
None:

<img width="717" alt="none"
src="https://github.com/zed-industries/zed/assets/2101250/b2a741db-c64a-4275-a612-5a0d15c9cab7">

Gutter:

<img width="715" alt="gutter"
src="https://github.com/zed-industries/zed/assets/2101250/f7a68a6e-6eba-41b4-9042-5a5fe2ee21a4">

Line:

<img width="717" alt="line"
src="https://github.com/zed-industries/zed/assets/2101250/117f5b00-abd7-425b-8047-1a6fab8293a7">

All:

<img width="715" alt="all"
src="https://github.com/zed-industries/zed/assets/2101250/ebccc0da-0fa0-44e5-903c-cc49d975db76">

This PR adds the `current_line_highlight` setting that defines how to
highlight the current line in the editor:

- `none`: Don't highlight the current line.
- `gutter`: Highlight the gutter area only.
- `line`: Highlight the editor area only.
- `all` (default): Highlight the whole line.

The options have been borrowed from VSCode.

Fixes #5222
Part of #4382

Release Notes:

- Added the `current_line_highlight` setting that defines how to
highlight the current line in the editor (#5222).
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
@alygin @osiewicz
editor: Current line highlight options (zed-industries#11710)
03db921 
None:

<img width="717" alt="none"
src="https://github.com/zed-industries/zed/assets/2101250/b2a741db-c64a-4275-a612-5a0d15c9cab7">

Gutter:

<img width="715" alt="gutter"
src="https://github.com/zed-industries/zed/assets/2101250/f7a68a6e-6eba-41b4-9042-5a5fe2ee21a4">

Line:

<img width="717" alt="line"
src="https://github.com/zed-industries/zed/assets/2101250/117f5b00-abd7-425b-8047-1a6fab8293a7">

All:

<img width="715" alt="all"
src="https://github.com/zed-industries/zed/assets/2101250/ebccc0da-0fa0-44e5-903c-cc49d975db76">

This PR adds the `current_line_highlight` setting that defines how to
highlight the current line in the editor:

- `none`: Don't highlight the current line.
- `gutter`: Highlight the gutter area only.
- `line`: Highlight the editor area only.
- `all` (default): Highlight the whole line.

The options have been borrowed from VSCode.

Fixes zed-industries#5222
Part of zed-industries#4382

Release Notes:

- Added the `current_line_highlight` setting that defines how to
highlight the current line in the editor (zed-industries#5222).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: Current line highlight options alygin/zed
2 participants
@chriskrycho @JosephTLyons