New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editor: Current line highlight options #11710
Merged
SomeoneToIgnore
merged 3 commits into
zed-industries:main
from
alygin:line-highlight-config
May 13, 2024
Merged
editor: Current line highlight options #11710
SomeoneToIgnore
merged 3 commits into
zed-industries:main
from
alygin:line-highlight-config
May 13, 2024
+112
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nice, thank you, I like the gutter-only highlights now 🙂
Let's fix a few small nits and get it merged.
SomeoneToIgnore
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs a rebase.
SomeoneToIgnore
added a commit
that referenced
this pull request
May 13, 2024
Follow-up of #11710 Release Notes: - Removed extra line highlights when deleted diff editors loose focus
osiewicz
pushed a commit
to RemcoSmitsDev/zed
that referenced
this pull request
May 18, 2024
None: <img width="717" alt="none" src="https://github.com/zed-industries/zed/assets/2101250/b2a741db-c64a-4275-a612-5a0d15c9cab7"> Gutter: <img width="715" alt="gutter" src="https://github.com/zed-industries/zed/assets/2101250/f7a68a6e-6eba-41b4-9042-5a5fe2ee21a4"> Line: <img width="717" alt="line" src="https://github.com/zed-industries/zed/assets/2101250/117f5b00-abd7-425b-8047-1a6fab8293a7"> All: <img width="715" alt="all" src="https://github.com/zed-industries/zed/assets/2101250/ebccc0da-0fa0-44e5-903c-cc49d975db76"> This PR adds the `current_line_highlight` setting that defines how to highlight the current line in the editor: - `none`: Don't highlight the current line. - `gutter`: Highlight the gutter area only. - `line`: Highlight the editor area only. - `all` (default): Highlight the whole line. The options have been borrowed from VSCode. Fixes zed-industries#5222 Part of zed-industries#4382 Release Notes: - Added the `current_line_highlight` setting that defines how to highlight the current line in the editor (zed-industries#5222).
osiewicz
pushed a commit
to RemcoSmitsDev/zed
that referenced
this pull request
May 18, 2024
…dustries#11772) Follow-up of zed-industries#11710 Release Notes: - Removed extra line highlights when deleted diff editors loose focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
current_line_highlight
setting that defines how to highlight the current line in the editor:none
: Don't highlight the current line.gutter
: Highlight the gutter area only.line
: Highlight the editor area only.all
(default): Highlight the whole line.The options have been borrowed from VSCode.
Fixes #5222
Part of #4382
Release Notes:
current_line_highlight
setting that defines how to highlight the current line in the editor (Ability to disable highlighting of current line #5222).None:
Gutter:
Line:
All: