New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search in selections #10831
base: main
Are you sure you want to change the base?
Search in selections #10831
Conversation
Hello, Zed team! Still WIP, couple of questions here:
Things TBD:
|
@kshokhin Hopefully @iamnbutler can help with getting the icon right. You might be able to reuse "quote" for now (as that's similar to VScode's icon; though pretty hard to interpret if you are not used to it :D) or "filter"? Either way we'll need a good tooltip. I'd love to pair with you on this as that's probably more effective than me guessing at how it should work in a comment :D – if you have time let's chat next week: https://calendly.com/conradirwin/pairing. We're also running into some overlap with @cthulhua's work on #10709; so I may need to reconsider what I put there too... Some thoughts in no particular order:
|
This PR is extremely useful when you are aware that theres a secondary way to do |
If you are able to get this to search inside of multiple disjoint selection, that would be killer. |
In #10709 we ended up allowing the editor to store "search within" ranges (though in that case we clear them as soon as we're done). I think we can build on that to make this work without having to be so careful about the selection. |
80503b7
to
5763d98
Compare
@kshokhin How're you getting on with this? Happy to take a look if you think it's ready |
* Remove SearchOptions::SELECTION * Make search in selection SearchableItem property instead of query property * Move search in selections button out of the query text box
I.e. set replace_enabled and selection_search_enabled flags to false
Likely the overhead from the tasks joining will be higher than the profit from the concurrency
5763d98
to
65a9d99
Compare
@ConradIrwin Sorry for the delays, not always manage to devote as much time as I want, please bear with me.
|
No problem – this seems to work great! I think the final thing we need is the default keybinding (in VSCode it's If you want help with tests, let me know. |
* cmd-alt-l for macos * ctrl-alt-l for linux * Toggle search ranges on BufferSearchBar deploy and update matches
Release Notes: