x11: Add XIM support #11657
Merged
x11: Add XIM support #11657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: npmania <np@mkv.li>
|
We require contributors to sign our Contributor License Agreement, and we don't have @npmania on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
cla-bot
bot
added
the
cla-signed
out2.mp4Here's a short video testing English, BQN, Korean, Japanese and Chinese input. |
Signed-off-by: npmania <np@mkv.li>
Signed-off-by: npmania <np@mkv.li>
Signed-off-by: npmania <np@mkv.li>
Signed-off-by: npmania <np@mkv.li>
3 tasks
|
Thank you for this work, it's been needed! Can you tell me a bit more about xim-rs? Is there a compelling reason to use it, rather than handling the xim messages ourselves? |
mikayla-maki
requested changes
May 13, 2024
The XIM protocol is not implemented in XCB, so communicating with XIM with the current xcb_ffi would require manual parsing of the XIM protocol. xim-rs provides an XIM protocol parsing interface over x11rb client, allowing non-blocking communication with the XIM server. |
|
Gotcha thanks for the context! I did some reading and research on XIM and have a better understanding of how this all fits together now :D |
mikayla-maki
requested changes
May 14, 2024
|
See handle_key_event on macOS for a rough guide on how IME and keyevents should interact. https://github.com/zed-industries/zed/blob/main/crates/gpui/src/platform/mac/window.rs#L1202-L1307 |
1 task
Signed-off-by: npmania <np@mkv.li>
Signed-off-by: npmania <np@mkv.li>
mikayla-maki
approved these changes
May 16, 2024
|
Seems that this PR needs a cargo fmt |
Signed-off-by: npmania <np@mkv.li>
|
Oops, fixed formatting on the last commit. I believe I've ran typo checker and clippy already, so hopefully the rest will be fine. |
|
|
|
@aohanhongzhi Please provide me about your setup so I can reproduce it on my environment. |
osiewicz
pushed a commit
to RemcoSmitsDev/zed
that referenced
this pull request
May 18, 2024
This pull request adds XIM (X Input Method) support to x11 platform. The implementation utilizes [xim-rs](https://crates.io/crates/xim), a XIM library written entirely in Rust, to provide asynchronous XIM communication. Preedit and candidate positioning are fully supported in the editor interface, yet notably absent in the terminal environment. This work is sponsored by [Rainlab Inc.](https://rainlab.co.jp/en/) Release Notes: - N/A --------- Signed-off-by: npmania <np@mkv.li>
I was able to reproduce that this is the |
|
@eatradish Thanks a lot! I will try to investigate into this issue in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds XIM (X Input Method) support to x11 platform.
The implementation utilizes xim-rs, a XIM library written entirely in Rust, to provide asynchronous XIM communication.
Preedit and candidate positioning are fully supported in the editor interface, yet notably absent in the terminal environment.
This work is sponsored by Rainlab Inc.
Release Notes: