Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Update crate Windows from 0.53 to 0.56 #11662

Merged
merged 3 commits into from May 14, 2024

Conversation

JunkuiZhang
Copy link
Contributor

Version 0.56 has fixed many of the previous bugs, and one of the bugs prevent me implementing some functions.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 10, 2024
@ognevny
Copy link
Contributor

ognevny commented May 11, 2024

cool, that adds i686_gnullvm support for windows

@JunkuiZhang
Copy link
Contributor Author

JunkuiZhang commented May 11, 2024

cool, that adds i686_gnullvm support for windows

I noticed that you closed your PR. I think this PR can be a good complement to yours, as mine simply updates the windows crate from 0.53 to 0.56, and there are updates to many crates in your PR that are not included in this one, such as updates to chrono.

@ognevny
Copy link
Contributor

ognevny commented May 11, 2024

cool, that adds i686_gnullvm support for windows

I noticed that you closed your PR. I think this PR can be a good complement to yours, as mine simply updates the windows crate from 0.53 to 0.56, and there are updates to many crates in your PR that are not included in this one, such as updates to chrono.

yours should be enough

@mikayla-maki
Copy link
Contributor

Thank you!

@mikayla-maki mikayla-maki merged commit 5154910 into zed-industries:main May 14, 2024
8 checks passed
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this pull request May 18, 2024
…#11662)

Version 0.56 has fixed many of the previous bugs, and one of the bugs
prevent me implementing some functions.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants